Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tests #4

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Fixed tests #4

merged 1 commit into from
Jul 16, 2023

Conversation

mpscholten
Copy link

@mpscholten mpscholten commented Jul 10, 2023 •
edited
Loading

This fixes tests by correctly enabling the session middleware to work. IHP's renderHtml accesses the session to clear possible flash messages 👍

@amitaibu
Copy link
Owner

Thanks.

@amitaibu amitaibu merged commit dbed108 into amitaibu:isActiveAction-alias Jul 16, 2023
@amitaibu amitaibu deleted the isActiveAction-alias branch July 16, 2023 12:11
amitaibu added a commit that referenced this pull request Jul 27, 2023
@amitaibu @mpscholten
isActiveAction should take query string into account (digitallyindu…
c5422cd 
…ced#1725)

* isActiveAction should take query string into account

* simplify code

* Add tests

* Fix tests

* Remove returns

* Try to add View

* Fixed tests (#4)

* Re-add controller test

* Update docs

---------

Co-authored-by: Marc Scholten <marc@digitallyinduced.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpscholten @amitaibu